Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keadm Tool Enhancement #5564

Merged
merged 1 commit into from
May 28, 2024
Merged

Keadm Tool Enhancement #5564

merged 1 commit into from
May 28, 2024

Conversation

HT0403
Copy link
Contributor

@HT0403 HT0403 commented Apr 25, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Keadm(KubeEdge installation tool) now only supports configuring a subset of parameters during EdgeCore installation. We would like to support specifying parameters using --set or directly using an existing local configuration file to achieve full parameter configuration and meet the users' requirements.

Which issue(s) this PR fixes:

Fixes #5563

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2024
@kubeedge-bot
Copy link
Collaborator

Welcome @HT0403! It looks like this is your first PR to kubeedge/kubeedge 🎉

@HT0403 HT0403 changed the title enhance keadm tool #5563 enhance keadm tool Apr 25, 2024
@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 25, 2024
@HT0403 HT0403 changed the title enhance keadm tool [WIP]enhance keadm tool Apr 25, 2024
@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
keadm/cmd/keadm/app/cmd/util/parser_test.go Outdated Show resolved Hide resolved
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 26, 2024
@HT0403 HT0403 force-pushed the master branch 2 times, most recently from e7ae554 to f4d0b2c Compare April 27, 2024 02:16
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2024
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2024
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2024
@HT0403 HT0403 changed the title [WIP]enhance keadm tool Enhance keadm tool May 15, 2024
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@HT0403 HT0403 changed the title Enhance keadm tool Keadm Tool Enhancement May 15, 2024
@WillardHu
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@WillardHu
Copy link
Collaborator

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@HT0403
Copy link
Contributor Author

HT0403 commented May 25, 2024

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2024
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
keadm/cmd/keadm/app/cmd/util/set.go Outdated Show resolved Hide resolved
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label May 25, 2024
…eve full parameter configuration by using --set

Signed-off-by: HT0403 <[email protected]>
@HT0403
Copy link
Contributor Author

HT0403 commented May 25, 2024

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot
Copy link
Collaborator

@wbc6080: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2024
@luomengY
Copy link
Member

/lgtm

@WillardHu
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WillardHu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@kubeedge-bot kubeedge-bot merged commit 5efd287 into kubeedge:master May 28, 2024
20 of 21 checks passed
@Shelley-BaoYue Shelley-BaoYue added this to the v1.18 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keadm Tool Enhancement
7 participants