Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-runtime: make ExponentialBackoff public #1716

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

gdeleon2
Copy link
Contributor

@gdeleon2 gdeleon2 commented Mar 9, 2025

Change ExponentialBackoff to public so that it is accessible for external use.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the interface is not really ready to expose as is, but i am open to some alternatives here.

maybe we can impl Default for ExponentialBackoff and maybe rename it to KubernetesBackoff or something to indicate it's an upstream convention.

if you do actually need to set the parameters, then maybe we can make the fields of that struct pub.

could you tell us a little bit about the use case for needing to instantiate this yourself?

@gdeleon2 gdeleon2 force-pushed the make-exponential-backoff-pub branch from ec64ba0 to 477dcea Compare March 11, 2025 09:15
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.1%. Comparing base (55e865c) to head (a62f925).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
kube-runtime/src/watcher.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1716     +/-   ##
=======================================
- Coverage   76.1%   76.1%   -0.0%     
=======================================
  Files         84      84             
  Lines       7858    7860      +2     
=======================================
  Hits        5977    5977             
- Misses      1881    1883      +2     
Files with missing lines Coverage Δ
kube-runtime/src/watcher.rs 42.8% <0.0%> (-0.3%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@clux clux added the changelog-add changelog added category for prs label Mar 11, 2025
@clux clux added this to the 0.99.0 milestone Mar 11, 2025
@clux clux merged commit b21a4e5 into kube-rs:main Mar 11, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants