Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tighten json-patch and jsonptr versions (#1700) #1701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Tighten json-patch and jsonptr versions (#1700) #1701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ hyper-rustls = { version = "0.27.1", default-features = false }
hyper-socks2 = { version = "0.9.0", default-features = false }
hyper-timeout = "0.5.1"
hyper-util = "0.1.9"
json-patch = "3"
json-patch = "3.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually a tighter bound? i'm pretty sure this is ignored on the app side. you'd have to pin with ^ afaikr

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is tighter, due to server rules - Cargo won't update it to 3.1 🙂

I first tried with pinning it, verified that this fixed the issue, and then removed the pin to just specify the minimum required version - this still works (verified locally) and it will allow patch updates but not minor version updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, ok. well, if it works. right now CI is massively red.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I must admit I don't have time to look into that at present - as all I've done is set the versions, and that fixes the problem locally, that should be sufficient (or useful for anyone else looking at this perhaps). If there is no other fix later then I could take a deeper look, but you may well decide to upgrade to the latest version instead of fixing to the older one 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at CI logs, it seems that build is pulling in jsonptr v0.7.1 regardless of our preference. I guess if they use it, we will have to use the one they use anyway.

Copy link
Member

@clux clux Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In related news, 3.1.0 was yanked and 4.0.0 was released, (due to this issue) so probably will give this a day or two, then update manually.

I see they are also re-exporting jsonptr now so we can stick to pinning one dep.

jsonpath-rust = "0.7.3"
jsonptr = "0.6"
jsonptr = "0.6.3"
k8s-openapi = { version = "0.24.0", default-features = false }
openssl = "0.10.36"
parking_lot = "0.12.0"
Expand Down
Loading