Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HAProxy #1352

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

nathankot
Copy link
Contributor

I can update the documentation if there is appetite for this :)
Note I haven't tested this with klipperlb

locals.tf Show resolved Hide resolved
mysticaltech
mysticaltech previously approved these changes May 23, 2024
@mysticaltech
Copy link
Collaborator

@nathankot This is great, thanks! Please add some docs, same as for the others, especially readme and kube.tf.example tweaks and will merge 🙏

@mysticaltech mysticaltech self-requested a review May 23, 2024 12:19
Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apart from docs, also apply terraform format, the command or use the terraform vscode extension to get the format right. Either way will work.

@nathankot
Copy link
Contributor Author

@mysticaltech i've run fmt and updated the example/readme files, looks like there is a github bot that updates the the terraform.md file so didn't touch that :)

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathankot, looking good to fly! 🚀 🙏

@mysticaltech mysticaltech merged commit 8c2179c into kube-hetzner:master Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants