spec: skip serializing several params if String is empty in Spec #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mount_label, rootfs_propagation, apparmor_profile or namespace path
not defined in config.json created by containerd/iSulad, kuasar will
use default value "" during deserializing Spec.
And when kuasar do serializing and store to new config.json created by
itself, those params will show in json with value "".
When Youki does deserializing, as it uses Spec in crate oci-spec, these
params' data types are Option<String>, so their values will be Some(""),
but youki only checks if the value is Some when using, which
causes lots of problems like `failed to open namespace file ""...`
Signed-off-by: Vanient <[email protected]>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mount_label, rootfs_propagation, apparmor_profile or namespace path not defined in config.json created by containerd/iSulad, kuasar will use default value "" during deserializing Spec.
And when kuasar do serializing and store to new config.json created by itself, those params will show in json with value "". When Youki does deserializing, as it uses Spec in crate oci-spec, these params' data types are Option, so their values will be Some(""), but youki only checks if the value is Some when using, which causes lots of problems like
failed to open namespace file ""...