Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support building with clang on ubuntu #414

Merged
merged 4 commits into from
May 16, 2024

Conversation

chokobole
Copy link
Contributor

@chokobole chokobole commented May 8, 2024

Description

This PR enables building tachyon with clang on ubuntu 22.04

@chokobole
Copy link
Contributor Author

Since a lint error has occurred in tachyon/base/threading/platform_thread_linux.cc, which belongs to Chromium, to keep the differences minimal, I kindly request that you ignore this 🙏

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b30a8f6
Please change the commit title to a constexpr (with `) to match the commit before

bd15530
Please change the commit message to this:
When linking rust tests with clang, clang detects and tries to use the system installed intel openmp even when compiling without the option --//:has_intel_openmp,.

docs/how_to_use/how_to_build.md Outdated Show resolved Hide resolved
docs/how_to_use/how_to_build.md Outdated Show resolved Hide resolved
docs/how_to_use/how_to_build.md Outdated Show resolved Hide resolved
@chokobole chokobole force-pushed the build/support-building-with-clang-on-ubuntu branch 2 times, most recently from a5753f9 to fc2fff0 Compare May 13, 2024 08:47
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong

This comment was marked as resolved.

Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the build/support-building-with-clang-on-ubuntu branch from fc2fff0 to 9867ba5 Compare May 16, 2024 02:04
When linking rust tests with clang, clang detects and tries to use
the system installed intel openmp even when compiling without the option
`--//:has_intel_openmp`.
@chokobole chokobole force-pushed the build/support-building-with-clang-on-ubuntu branch from 9867ba5 to 7699a73 Compare May 16, 2024 02:04
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit bddedb6 into main May 16, 2024
2 of 3 checks passed
@chokobole chokobole deleted the build/support-building-with-clang-on-ubuntu branch May 16, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants