-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support building with clang on ubuntu #414
Conversation
Since a lint error has occurred in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b30a8f6
Please change the commit title to a constexpr
(with `) to match the commit before
bd15530
Please change the commit message to this:
When linking rust tests with clang, clang detects and tries to use the system installed intel openmp even when compiling without the option --//:has_intel_openmp
,.
a5753f9
to
fc2fff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fc2fff0
to
9867ba5
Compare
When linking rust tests with clang, clang detects and tries to use the system installed intel openmp even when compiling without the option `--//:has_intel_openmp`.
9867ba5
to
7699a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR enables building tachyon with clang on ubuntu 22.04