13 adding interface to pluralizer to enable testing (#14)

* feat: add interface to pluralizer * chore: fixed wrong logging
krateoplatformops · Feb 12, 2025 · 5e3a9c1 · 5e3a9c1
1 parent d91ccf2
commit 5e3a9c1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/controller/worker.go b/pkg/controller/worker.go
@@ -47,7 +47,7 @@ func (c *Controller) handleErr(err error, obj event.Event) {
 
 	if retries := c.queue.NumRequeues(obj); retries < maxRetries {
 		c.logger.WithValues("retries", retries).
-			WithValues("obj", fmt.Sprintf("%v", obj)).
+			WithValues("obj", fmt.Sprintf("%v", obj.EventType)).
 			Debug("processing event, retrying", "error", err)
 
 		dig := event.DigestForEvent(obj)
@@ -71,7 +71,7 @@ func (c *Controller) processItem(ctx context.Context, obj interface{}) error {
 
 	el, err := c.fetch(ctx, evt.ObjectRef, false)
 	if err != nil {
-		c.logger.Debug("Resolving unstructured object", "error", evt.ObjectRef.String())
+		// if the object is not found, we will not retry to process it and we not throw an error
 		return nil
 	}
 

diff --git a/pkg/pluralizer/pluralizer.go b/pkg/pluralizer/pluralizer.go
@@ -15,6 +15,10 @@ type names struct {
 	Shorts   []string `json:"shorts"`
 }
 
+type PluralizerInterface interface {
+	GVKtoGVR(gvk schema.GroupVersionKind) (schema.GroupVersionResource, error)
+}
+
 type Pluralizer struct {
 	urlPlurals *string
 	cli        *http.Client