Advanced Options for Single Crystal Elastic mode of DNS Reduction GUI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add link to NXevent_data in LoadEventNexus algorithm docs
The algorithm uses private member variables that need to be cleared to prevent previously calculated values being returned if an instance of the algorithm is run twice. In addition, the algorithm provides some optional diagnostic output properties that we provide default values for. If the algorithm is being run as a child then these can incorrectly remain populated with previous values if we do not clear them when they are not required. It seems that setting the property value to it's current value (to deliberately retain any edits the user has made to that) is sufficient to clear the associated output workspace.
This was pointed out in mantidproject#35837
…iagnostics-unable-to-load-file Fix error in ISIS Diagnostics tab of Indirect Reduction
This code was supposed to return the last time if none of the times are after 1991, but the index was one greater than it should be if no suitable times were found. Co-authored-by: Jonathan Haigh <[email protected]>
…_tooltips Fix ISIS SANS Event Binning Tooltips
The previous statement for introducing 'Hmag' into the function
string never actually happened because it was inserted into the else
part of the self.MAGNETISATION check. The logic was the following:
if MAGNETISATION:
do something
else:
# everything here is NOT MAGNETISATION
if MAGNETISATION:
out += 'Hmag' # never happened
I changed the if statement to MAGNETICMOMENT,
so that if not MAGNETISATION, but if MAGNETICMOMENT,
then 'Hmag' gets added to the function string.
I assume this was the intended behaviour, which is also
supported by the previous comments in the code.
…_ornlnext Pull changes from main into ornl-next
- Added Validation to ensure all input workspaces have units of wavelength - Apply Suggested Chnanges from PR
cleanup and or statement
Update to C++ 20 standard
A few things needed fixing to remove compilation errors and warnings: - requires is now a keyword so we can't use it as a variable name - The function in Plot.cpp that used std::move to return generated a warning for an unnecessary move - The accumulate functions in MultiFileNameParser.cpp didn't compile unless they returned by value - Ambiguous overload for == operator (bool == Mantid::API::Boolean) in FindClusterFacesTest - Ambiguous == in EventListTest - Stricter class template checking meant remove <T> in TableWorkspaceTest - std::result_of has been deprecated and replaced by std::invoke_result
These warnings appeared when using C++ 20 with gcc. Two appeared erroneous, I fixed three, one was due to a known problem with boost::export.
- constexpr char* is now constexpr const char* - Made HKL namespace explicit to avoid ambiguity - shared_ptr::unique no longer exists, use_count==1 is closest equivalent - Stricter rules around templated classes resulted in the need to make equality comparisons clearer for the compiler - Changed some char* to std::string in a couple of methods
Equality operators defined to compare the base type to a derived type can now cause warnings in C++ 20. The compiler complained that the comparison is not reversible, i.e. a==b and b==a
These were generating clang warnings on MacOS
…-compare-workspaces Fix relative comparison in `CompareWorkspaces`
…theta-with-numeric-axis Fix BayesQuasi when sample workspace has numeric axis
…BUsingMinMaxD Remove FindUBUsingMinMaxD algorithm
Abins: support "high precision" GAUSSIAN frequency calculations
…l-next Fix relative comparison in `CompareWorkspaces` - `ornl-next`
…l-next Update to C++ 20 standard - ornl-next
…enblas_explanation Add libopenblas v0.3.28 notes to build configs
…rystal_elastic_upload_main_skeleton_part_1 Main skeleton for Single Crystal Elastic mode of DNS Reduction GUI
koshchii
force-pushed
the
dns_gui_single_crystal_elastic_upload_main_skeleton_part_2
branch
from
f21eb2e to
2ede503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR contains advanced data reduction options selection capabilities for the Single Cristal Elastic mode of DNS Reduction GUI. Complete integration of the Single Cristal Elastic mode into the DNS Reduction GUI will be implemented in several steps (in order to ensure reasonable PR sizes and reduce the workload for the reviewers), and this PR represents the 5th step of the integration process.
Summary of work
To test:
cmake --build . --target docs-htmlin build folder to create docs)This does not require release notes because this PR contains limited functionality for data reduction. Release notes for the Single Cristal Elastic mode will be included in a subsequent PR, once all components for implementing the data reduction workflow are uploaded.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.