fix frontend tests #11784
Merged
fix frontend tests #11784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't carry over some old settings. Additionally, avoid clobbering the standard reader settings.
Group tests by file type (EPUB or PDF).
Reduce time to run those tests by 95% on my machine (~17s → 0.8s).
Work on a copy of `test/sample.pdf`.
Work on a copy of `test/sample.pdf`.
Reduce time to run those tests by 74% on my machine (~8.8s → ~2.3s).
benoit-pierre
force-pushed
the
pr/fix_frontend_tests
branch
from
03e0459
to
cebc98f
Compare
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. discussion in #11775.
This change is