Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if /usr/bin symlink is present to fix instance reuse issue on older Pocketbooks #11764

Merged
merged 3 commits into from May 13, 2024

Conversation

sdasda7777
Copy link
Contributor

@sdasda7777 sdasda7777 commented May 6, 2024

I believe this fixes #11760


This change is Reviewable

@Frenzie Frenzie requested a review from rjd22 May 6, 2024 19:40
@Frenzie
Copy link
Member

Frenzie commented May 6, 2024

/usr/bin sounds theoretically preferable to me (with a fallback for older devices) but I'll refrain from opining on PB.

@sdasda7777
Copy link
Contributor Author

Makes sense to me, I'll look into it.

@sdasda7777 sdasda7777 changed the title Skip /usr/bin symlink to fix taskswitching issue on older Pocketbooks Check if /usr/bin symlink is present to fix taskswitching issue on older Pocketbooks May 6, 2024
@sdasda7777 sdasda7777 changed the title Check if /usr/bin symlink is present to fix taskswitching issue on older Pocketbooks Check if /usr/bin symlink is present to fix instance reuse issue on older Pocketbooks May 6, 2024
@sdasda7777
Copy link
Contributor Author

Hi, does anyone have any concerns as to why this should not be merged?

@Frenzie Frenzie added this to the 2024.05 milestone May 13, 2024
@Frenzie Frenzie merged commit eb7af99 into koreader:master May 13, 2024
3 checks passed
@Frenzie
Copy link
Member

Frenzie commented May 13, 2024

No concerns, just waiting for potential comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open books from library when files are associated on some Pocketbooks
3 participants