Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add the repository description to taskbar #3565

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lupusA
Copy link
Contributor

@lupusA lupusA commented Jan 11, 2024

Hi,

this PR adds the repository description to the taskbar while starting up or initializing kopia. It was mentioned that, if there is no connection to the repository, multiple "initializing" or "not connected" repository show up. It is not easy to distinguish between multiple repositories in this case.

  • While calling newServerForRepo, the corresponding config is read to extract the description
  • The description is then added to the taskbar
  • The read operation for the repository config is async, not blocking the creation of the server
  • Removed deprecated call of file.resolvePath

Feedback is welcomed. This PR partly refers to #3418.

Aufzeichnung.2024-01-11.202045.mp4

Cheers,

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.95%. Comparing base (cb455c6) to head (4819213).
Report is 92 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3565      +/-   ##
==========================================
+ Coverage   75.86%   76.95%   +1.08%     
==========================================
  Files         470      476       +6     
  Lines       37301    29039    -8262     
==========================================
- Hits        28299    22346    -5953     
+ Misses       7071     4750    -2321     
- Partials     1931     1943      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lupusA lupusA requested a review from jkowalski January 11, 2024 19:26
@lupusA lupusA added enhancement ux User eXperience labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ux User eXperience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant