Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fix validation of --manual and --run-missed when setting policy #3348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhracturedBlue
Copy link
Contributor

As discovered while debugging #3344 when RunMissed was converted to a tri-state, the validation checks when setting --manual on the --global policy fail.

This is a small PR to address that and add an appropriate test for it.

@PhracturedBlue PhracturedBlue changed the title fix(cli): Fix --manual interatcion with --run-missed fix(cli): Fix validation of --manual and --run-missed when setting policy Sep 23, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (814738c) 75.88% compared to head (51888ad) 75.86%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
- Coverage   75.88%   75.86%   -0.02%     
==========================================
  Files         462      462              
  Lines       37082    37082              
==========================================
- Hits        28138    28133       -5     
- Misses       7020     7021       +1     
- Partials     1924     1928       +4     
Files Coverage Δ
snapshot/policy/scheduling_policy.go 85.07% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant