Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): write CACHEDIR.TAG to log directories #3147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NickIAm
Copy link
Contributor

@NickIAm NickIAm commented Jul 15, 2023

Write a CACHEDIR.TAG file to the ~/.cache/kopia directory to exclude cli-logs and address #2822. Get the path to write the cachetag file by going up 1 level from the content cache where it was previously written.

@jkowalski
Copy link
Contributor

jkowalski commented Jul 16, 2023

can we write the marker to the logs directory directly instead of the parent?

The issue is that on Linux logs are under ~/.cache/kopia, which is kind of weird, on macOS we have dedicated directories for logs.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd1ebb1) 75.81% compared to head (2e2e21b) 75.40%.

❗ Current head 2e2e21b differs from pull request most recent head 381eb49. Consider uploading reports for the commit 381eb49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   75.81%   75.40%   -0.41%     
==========================================
  Files         465      459       -6     
  Lines       37165    36343     -822     
==========================================
- Hits        28176    27404     -772     
+ Misses       7056     7024      -32     
+ Partials     1933     1915      -18     
Files Coverage Δ
repo/format/format_blob_cache.go 82.95% <66.66%> (+0.39%) ⬆️

... and 100 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickIAm
Copy link
Contributor Author

NickIAm commented Jul 20, 2023

Yeah I can change it. Didn't realize that logs are in a different directory on Mac, I don't have access to one.

@NickIAm NickIAm changed the title fix(cli): write CACHEDIR.TAG to ~/.cache/kopia fix(cli): write CACHEDIR.TAG to log directories Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants