fix(snapshots): choose numCPU if less than max parallel value #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinyiZou
changed the title
MinyiZou
changed the title
MinyiZou
changed the title
jkowalski
reviewed
Jun 14, 2023
| @@ -744,6 +744,11 @@ func (u *Uploader) maybeIgnoreCachedEntry(ctx context.Context, ent fs.Entry) fs. | |||
|
|
|||
| func (u *Uploader) effectiveParallelFileReads(pol *policy.Policy) int { | |||
| p := u.ParallelUploads | |||
|
|
|||
| if p > runtime.NumCPU() { | |||
There was a problem hiding this comment.
given that uploads are not entirely CPU bound there may be benefits to allowing p to be greater than the number of cores to allow max number of cores to do hashing while others are waiting for uploads
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
- Coverage 75.29% 75.29% -0.01%
==========================================
Files 457 457
Lines 36093 36097 +4
==========================================
+ Hits 27177 27179 +2
- Misses 7006 7010 +4
+ Partials 1910 1908 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3068 Kopia parallelism: choose numCPU if less than max parallel value