Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: remove reservation nominator useless code #1990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xulinfei1996
Copy link
Contributor

Ⅰ. Describe what this PR does

If Reservation is Active, Failed or Succeed, it must be scheduled after it triggers preemption, so its nominated information will be deleted in this round schedule process. As in the framework, it will exec DeleteNominatedReservePod in RunReservePluginsReserve.
In a conclusion, it is no need to DeleteReservePod in ReservationHandler OnUpdate handler.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign buptcozy after the PR has been reviewed.
You can assign the PR to them by writing /assign @buptcozy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saintube
Copy link
Member

saintube commented May 7, 2024

Ⅰ. Describe what this PR does

If Reservation is Active, Failed or Succeed, it must be scheduled after it triggers preemption, so its nominated information will be deleted in this round schedule process.

AFAIK, the reservation would not get scheduled (enqueue the SchedulingQueue) when its phase becomes Available, Failed, or Succeeded. Besides, deleting an unreserved reservation pod in the nominator seems idempotent. So I'm wondering if removing the deletion of the nominated reservation is correct and required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants