Dockerize Upgrade + Proper ARM Support #112
Open
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to upgrade the Docker setup and improve ARM support.
- Added a pull_request trigger in the CI/CD workflow to automate checks for pull requests.
Files not reviewed (11)
- 8.0-prod/Dockerfile: Language not supported
- 8.0/Dockerfile: Language not supported
- 8.1-prod/Dockerfile: Language not supported
- 8.1/Dockerfile: Language not supported
- 8.2-prod/Dockerfile: Language not supported
- 8.2/Dockerfile: Language not supported
- 8.3-prod/Dockerfile: Language not supported
- 8.3/Dockerfile: Language not supported
- 8.4-prod/Dockerfile: Language not supported
- 8.4/Dockerfile: Language not supported
- template/Dockerfile.blade.php: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two main changes: enabling CI/CD workflows for pull requests and updating Dockerfiles to use a more recent and architecture-aware version of the
dockerizetool. These updates improve the CI/CD process and ensure compatibility with different system architectures.CI/CD Workflow Updates:
.github/workflows/ci-cd.yml. This ensures that pull requests are automatically tested, improving code quality and reducing manual intervention.Dockerfile Updates:
dockerizetool to version0.9.3in all Dockerfiles (8.0,8.1,8.2,8.3,8.4and their-prodvariants) and thetemplate/Dockerfile.blade.php. The new version dynamically determines the system architecture (arm64oramd64) to ensure compatibility with both ARM and x86 systems. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]