Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Drop use of @migtools/lib-ui #2193

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Mar 6, 2025

Resolves: #2044

To have direct control over storage and selection
hooks used in the project, pull in the used code
from @migtools/lib-ui and drop it as a dependency.

Changes:

  • Drop @migtools/lib-ui from dependencies
  • Pull in hooks useSelectionState() and useStorage()
  • Adjust components to use the project's versions of the hooks

Source: https://github.com/migtools/lib-ui
Tag: v10.0.1
Commit SHA: 0cb74ce6d4de236abe1b7d20bbe747ceca392f28

Resolves: konveyor#2044

To have direct control over storage and selection
hooks used in the project, pull in the used code
from `@migtools/lib-ui` and drop it as a dependency.

Changes:
  - Drop `@migtools/lib-ui` from dependencies
  - Pull in hooks useSelectionState() and useStorage()
  - Adjust components to use the project's versions
    of the hooks

Signed-off-by: Scott J Dickerson <[email protected]>
Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please include in the commit message (PR description) a link to the git tag in the @migtools/lib-ui repo that was used.

@sjd78 sjd78 added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Mar 7, 2025
@sjd78 sjd78 merged commit e9a410c into konveyor:main Mar 7, 2025
13 checks passed
@sjd78 sjd78 deleted the remove_migtools branch March 7, 2025 14:08
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Mar 7, 2025
Backport of: konveyor#2193
Resolves: konveyor#2044

To have direct control over storage and selection
hooks used in the project, pull in the used code
from `@migtools/lib-ui` and drop it as a dependency.

Changes:
  - Drop `@migtools/lib-ui` from dependencies
  - Pull in hooks useSelectionState() and useStorage()
  - Adjust components to use the project's versions of the hooks

Source: https://github.com/migtools/lib-ui
Tag: [v10.0.1](https://github.com/migtools/lib-ui/tree/v10.0.1)
Commit SHA: 0cb74ce6d4de236abe1b7d20bbe747ceca392f28

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit that referenced this pull request Mar 10, 2025
Backport of: #2193
Resolves: #2044

To have direct control over storage and selection
hooks used in the project, pull in the used code
from `@migtools/lib-ui` and drop it as a dependency.

Changes:
  - Drop `@migtools/lib-ui` from dependencies
  - Pull in hooks useSelectionState() and useStorage()
  - Adjust components to use the project's versions of the hooks

Source: https://github.com/migtools/lib-ui
Tag: [v10.0.1](https://github.com/migtools/lib-ui/tree/v10.0.1)
Commit SHA: 0cb74ce6d4de236abe1b7d20bbe747ceca392f28

Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the use of @migtools/lib-ui
2 participants