Provide options for taxonomy elements (terms) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it cannot be a dynamic dropdown, because there is no way to pass the dropdown info about the element it needs to fill => no way to know the taxonomy group to fetch
IvanKiral
reviewed
Mar 24, 2023
| const idChoices = terms.map(t => ({ value: t.id, label: t.name, sample: t.id })); | ||
| const codenameChoices = terms.map(t => ({ value: t.codename, label: `${t.name} (codename)`, sample: t.codename })); | ||
|
|
||
| return getField(element, { type: 'unicode', choices: [...idChoices, ...codenameChoices], list: true }); |
There was a problem hiding this comment.
Is it not possible to have two tabs one for id and one for codename?
There was a problem hiding this comment.
I am no sure what you mean by tabs, but it is possible to have two separate fields and then choose one of them at runtime. It is an unfortunate situation, because we need both options to be able to accept both identifiers from previous steps, but in the dropdown in the UI, we would ideally want just one of them.
|
Since this PR introduces a breaking change and is not of high priority, we will wait with this change until there will be more breaking changes and merge it with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds options for taxonomy elements. Fixes #13
Checklist
How to test
Check it is possible to correctly create an item with a taxonomy element and the input provides choices with the taxonomy group's terms.