Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix awaiting rollback function #52

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix awaiting rollback function #52

merged 1 commit into from
Jun 22, 2023

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #51

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

  1. Create a migration with a rollback function specified
  2. Try to execute migration with --rollback switch

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #52 (f72c71b) into master (3cd3ae7) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   65.76%   65.58%   -0.19%     
==========================================
  Files           9        9              
  Lines         371      369       -2     
  Branches       98       96       -2     
==========================================
- Hits          244      242       -2     
  Misses        126      126              
  Partials        1        1              
Impacted Files Coverage Δ
src/utils/migrationUtils.ts 58.19% <100.00%> (-0.68%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winklertomas winklertomas merged commit 3b2f897 into master Jun 22, 2023
3 checks passed
@winklertomas winklertomas deleted the fix_rollback branch June 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollback function does not execute
2 participants