Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running without cluster.yml when tf_json present #1418

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kke
Copy link
Contributor

@kke kke commented Jun 18, 2019

With TF 0.12 it's possible to generate the full config from TF, no need to provider cluster.yml then.

@kke kke added the enhancement New feature or request label Jun 18, 2019
@@ -45,8 +45,8 @@ def default_config_yaml
Pharos::YamlFile.new($stdin, force_erb: true, override_filename: '<stdin>')
else
cluster_config = Dir.glob('cluster.{yml,yml.erb}').first
signal_usage_error 'File does not exist: cluster.yml' if cluster_config.nil?
Pharos::YamlFile.new(cluster_config)
signal_usage_error 'File does not exist: cluster.yml' if cluster_config.nil? && !tf_json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is tf_json always available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it checks .nil?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: will self.respond_to?(:tf_json) always?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in terraform apply, it only has --config.

@jakolehm jakolehm changed the title Allow running without cluster.yml when tf_json present [cluster-e2e] Allow running without cluster.yml when tf_json present Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants