Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrency slightly gracefully #14

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Handle concurrency slightly gracefully #14

merged 1 commit into from
Oct 21, 2020

Conversation

ritchxu
Copy link
Contributor

@ritchxu ritchxu commented Oct 20, 2020

In case when multiple events triggered the action (create new issue and add label), we observed error of HttpError: Validation Failed for some runs. This PR catches such cases and recheck if card was already added and if so proceed without error. The solution is not fool-proof, but should reduce the chance of false positive failed runs.

May help #6 and #11.

@konradpabjan konradpabjan merged commit 20fd6c6 into konradpabjan:master Oct 21, 2020
@ritchxu ritchxu deleted the ritchxu/concurrency branch October 21, 2020 19:02
@congyiwu
Copy link

congyiwu commented Feb 4, 2021

@konradpabjan should this be tagged as a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants