Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. Fixes for lastpass-python #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

guilt
Copy link

@guilt guilt commented Aug 20, 2019

Hi,

This pull request has some changes in it, including some SecureNote parsing code that was borrowed and improved. Update: Moved the lpass CLI to a separate repo (https://github.com/guilt/lastpass-python-cli)

It's to help someone who was looking for how to get some of the notes data in Python. Please adapt this to your convenience.

Thanks to all the authors who had written some of the original code I took this off.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (41af73a) 72.72% compared to head (9a31f9d) 59.79%.

❗ Current head 9a31f9d differs from pull request most recent head 5b683b3. Consider uploading reports for the commit 5b683b3 to get more accurate results

Files Patch % Lines
lastpass/parser.py 42.35% 49 Missing ⚠️
lastpass/vault.py 27.50% 29 Missing ⚠️
lastpass/account.py 37.50% 15 Missing ⚠️
lastpass/fetcher.py 82.35% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #36       +/-   ##
===========================================
- Coverage   72.72%   59.79%   -12.93%     
===========================================
  Files          10        9        -1     
  Lines         385      592      +207     
===========================================
+ Hits          280      354       +74     
- Misses        105      238      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guilt guilt force-pushed the master branch 2 times, most recently from 70706a5 to 6d75a9e Compare August 22, 2019 04:11
@combro2k
Copy link

Would love to see these changes, I am trying to replace lastpass cli's implementation.
And use this library for a gtk application :-) so would love the possibility to have the same kind of settings to store the database locally and reauth when a specific time is elapsed :-)
These changes allow me to create such thing :-)

…ss-python.

Import SecureNote parsing code, with changes from nadavshalev/lastpass-python.
Pylint pass and uncrustify code.
Fix pycodestyle issues.
@guilt guilt changed the title Misc. Fixes for lastpass-python + lpass Utility Misc. Fixes for lastpass-python Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants