Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added NetworkError reason and status code #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arossert
Copy link

Adding more information on network errors

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #35 into master will decrease coverage by 17.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #35       +/-   ##
==========================================
- Coverage   89.86%   72.7%   -17.17%     
==========================================
  Files           9       9               
  Lines         306     381       +75     
==========================================
+ Hits          275     277        +2     
- Misses         31     104       +73
Impacted Files Coverage Δ
lastpass/fetcher.py 60.83% <100%> (-35.22%) ⬇️
lastpass/parser.py 72.02% <0%> (-15.03%) ⬇️
lastpass/vault.py 75.6% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5063911...cd5c8ce. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #35 into master will decrease coverage by 17.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #35       +/-   ##
==========================================
- Coverage   89.86%   72.7%   -17.17%     
==========================================
  Files           9       9               
  Lines         306     381       +75     
==========================================
+ Hits          275     277        +2     
- Misses         31     104       +73
Impacted Files Coverage Δ
lastpass/fetcher.py 60.83% <100%> (-35.22%) ⬇️
lastpass/parser.py 72.02% <0%> (-15.03%) ⬇️
lastpass/vault.py 75.6% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5063911...a1c0d8d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants