Fix: Library Filter not working if grouping has to group

[cuong-tran]

Summary by Sourcery

Bug Fixes:

• Fixed a potential issue with library settings dialog when no active category is selected

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug in the library filter that prevented it from working correctly when grouping was enabled. The fix involves removing a null check for the category in the LibrarySettingsDialog composable function.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Fixed a bug where the library filter would not work correctly when grouping was enabled.	Removed a null check for the category in the LibrarySettingsDialog composable function.	app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryTab.kt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Hello @cuong-tran, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue where the Library Filter was not functioning correctly when grouping was enabled. The change involves removing a conditional check that was causing the settings dialog to be dismissed prematurely when the category was null. This ensures that the Library Settings Dialog is always displayed, even when the active category is not available.

Highlights

• Bug Fix: The Library Filter was not working correctly when grouping was enabled.
• Conditional Check Removal: A conditional check that was causing the settings dialog to be dismissed prematurely has been removed.
• Dialog Display: The Library Settings Dialog is now always displayed, even when the active category is not available.

Changelog

• app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryTab.kt
  • Removed a conditional check that was causing the settings dialog to be dismissed prematurely when the category was null (lines 270-273).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

Kotlin, the primary language used in Android development, is named after an island near St. Petersburg. JetBrains, the company that created Kotlin, is based in St. Petersburg.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where the library filter was not functioning correctly when grouping was enabled. The changes involve removing a null check for the category in LibraryTab.kt. Overall, the change seems straightforward and targeted at fixing the reported bug.

Summary of Findings

• Unnecessary Null Check Removal: The removal of the null check for the category might introduce a potential risk if state.categories is empty or if screenModel.activeCategoryIndex is out of bounds. While it fixes the reported issue, it's crucial to ensure that this change doesn't lead to other unexpected behaviors or crashes.

Merge Readiness

The pull request seems to address the reported issue, but the removal of the null check warrants careful consideration. While I cannot directly approve the pull request, I recommend ensuring that the removal of the null check doesn't introduce any new issues before merging. Another reviewer should confirm that the change is safe and doesn't negatively impact other parts of the application.

[sourcery-ai]

Hey @cuong-tran - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why the null check was removed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}