Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #619

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Spelling #619

wants to merge 28 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Mar 8, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@4fb7db8#commitcomment-68211017

The action reports that the changes in this PR would make it happy: jsoref@42e8fda

I haven't included the changes to the localizations which means they will all break. In testing, the changes apply cleanly. I can trivially include them if desired. My experience w/ localization projects is that about half of them manage translations separately and thus I can never guess who would want me to include the fixes and who wouldn't.

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes were automatically suggested by Google Sheets.

This is one of the first projects I've touched in a while that's heavily localized and intermixed with non-English content. That didn't seem to hurt my tooling.

I can easily drop or split things as requested. Splits by file type or directories are fairly trivial

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
fireEvent.press(screen.getByText(/adress/i))
fireEvent.press(screen.getByText(/address/i))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious. I can't imagine it working both ways...

"abbrevations": {
"abbreviations": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file would need to be applied to its siblings in order to not break the world.

Github
GitHub
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand

EMAILHOME: 'allan.fridell@mailinater.com',
EMAILHOME: 'allan.fridell@mailinator.com',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a sample, I'd argue that it should be @mailinator.example.com to make that clear.

"motherTounge": "Mother tongue tuition",
"motherTongue": "Mother tongue tuition",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, this change would need to be applied to its silblings.

jsoref added 20 commits March 8, 2022 05:54
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants