Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set docker-compose version to a valid value #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LilyFoote
Copy link
Collaborator

3.8 is the latest version and it works, so lets go with that.

3.8 is the latest version and it works, so lets go with that.
@LilyFoote LilyFoote self-assigned this Jan 31, 2022
Copy link
Member

@wilhelmklopp wilhelmklopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 3.8 refer to the version of docker compose?

Curious what's breaking on higher versions. (I have no context here at all 😅 )

@LilyFoote
Copy link
Collaborator Author

Actually, the problem I ran into is that not specifying the version here means version 1, which is deprecated.

@LilyFoote
Copy link
Collaborator Author

Actually, I think not specifying a version means either version 1, or the new "compose specification". The compose specification requires docker-compose 1.27.0+ whereas I have 1.25.5. So version 3.8 is a version I can use.

https://docs.docker.com/compose/compose-file/compose-versioning/#compatibility-matrix

Perhaps in this case, we don't need to merge this PR and I just edit the config locally.

Without this, requests would timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants