-
Notifications
You must be signed in to change notification settings - Fork 326
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reinstate and improve Feed::parse tests
Original test was being skipped because it was hitting the internet - the major relevant functionality here is the parsing rather than the remote access. Added local example feeds for RSS2.0 as well as the previously tested atom feed. Also improved the tests to check for the title as well as the number of elements since we now have known content to work with.
- Loading branch information
Showing
3 changed files
with
87 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<feed xmlns="http://www.w3.org/2005/Atom"> | ||
<title>Kohana v3.x: Activity</title> | ||
<link href="http://dev.kohanaframework.org/projects/kohana3/activity.atom" rel="self"/> | ||
<link href="http://dev.kohanaframework.org/projects/kohana3/activity" rel="alternate"/> | ||
<id>http://dev.kohanaframework.org/</id> | ||
<icon>http://dev.kohanaframework.org/favicon.ico?1392677580</icon> | ||
<updated>2014-08-28T01:52:12Z</updated> | ||
<author> | ||
<name>Kohana Development</name> | ||
</author> | ||
<generator uri="http://www.redmine.org/"> | ||
Redmine </generator> | ||
<entry> | ||
<title>Proposals (Political/Workflow) #4839 (New)</title> | ||
<link href="http://dev.kohanaframework.org/issues/4839" rel="alternate"/> | ||
<id>http://dev.kohanaframework.org/issues/4839</id> | ||
<updated>2014-08-28T01:52:12Z</updated> | ||
<author> | ||
<name>Guillaume Poirier-Morency</name> | ||
<email>[email protected]</email> | ||
</author> | ||
<content type="html"> | ||
<p>I have a prototype here <a class="external" href="https://github.com/arteymix/kohana-makefile">https://github.com/arteymix/kohana-makefile</a></p> | ||
|
||
|
||
<p>The tool is very useful for settings permissions and running tests.</p> | ||
|
||
|
||
<p>I think we should consider having a good make tool in the sample application for the 3.4.*.</p> </content> | ||
</entry> | ||
<entry> | ||
<title>Proposals (Political/Workflow) #4782</title> | ||
<link href="http://dev.kohanaframework.org/issues/4782#change-17279" rel="alternate"/> | ||
<id>http://dev.kohanaframework.org/issues/4782#change-17279</id> | ||
<updated>2014-08-28T01:44:26Z</updated> | ||
<author> | ||
<name>Guillaume Poirier-Morency</name> | ||
<email>[email protected]</email> | ||
</author> | ||
<content type="html"> | ||
<p>Moving to composer is a nice idea. This will allow Kohana modules to define a wide range of dependencies.</p> | ||
|
||
|
||
<p>Although, I think that modules designed specifically for Kohana should end in modules and external libraries in application/vendor. This makes a clear dinsinction between what gets autoloaded by the CFS and what gets loaded by composer. Technically, we add "vendor-dir": "application/vendor" in "config" in composer.json.</p> | ||
|
||
|
||
<p>Then, only add a line after the modules loading in bootstrap.php</p> | ||
|
||
|
||
<pre> | ||
// Autoloading composer packages | ||
require Kohana::find_file('vendor', 'autoload'); | ||
</pre> | ||
|
||
<p>This is pretty much what I do right now. This doesn't break anything and allow a full access to composer.</p> </content> | ||
</entry> | ||
</feed> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<rss version="2.0"> | ||
<channel> | ||
<title>RSS Title</title> | ||
<description>This is an example of an RSS feed</description> | ||
<link>http://www.example.com/main.html</link> | ||
<lastBuildDate>Mon, 06 Sep 2010 00:01:00 +0000 </lastBuildDate> | ||
<pubDate>Sun, 06 Sep 2009 16:20:00 +0000</pubDate> | ||
<ttl>1800</ttl> | ||
|
||
<item> | ||
<title>Example entry</title> | ||
<description>Here is some text containing an interesting description.</description> | ||
<link>http://www.example.com/blog/post/1</link> | ||
<guid>7bd204c6-1655-4c27-aeee-53f933c5395f</guid> | ||
<pubDate>Sun, 06 Sep 2009 16:20:00 +0000</pubDate> | ||
</item> | ||
|
||
</channel> | ||
</rss> |