Add support of nested collections #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
force-pushed
the
nested_collections
branch
2 times, most recently
from
c214e71
to
dbcf354
Compare
|
now rebased |
|
@knaufk could you please have a look once you have time? |
knaufk
force-pushed
the
nested_collections
branch
2 times, most recently
from
98c833d
to
b2b6500
Compare
|
Thank you for your patience. I've rebased. I am not 100% sure about the syntax. Can you elaborate why the |
|
yes, CREATE TEMPORARY TABLE t (
`arrays` ARRAY<ARRAY<ARRAY<STRING>>>
) WITH (
'connector' = 'faker',
'fields.arrays.element.element.expression' = '#{harry_potter.character}',
'fields.arrays.element.element.length' = '2',
'fields.arrays.element.length' = '3',
'fields.arrays.length' = '4',
'fields.arrays.element.element.null-rate' = '0.1',
'fields.arrays.element.null-rate' = '0.1',
'fields.arrays.null-rate' = '0.1'
);
UPD: the issue below could be fixed with apache/flink#19254 Flink 1.14.3's NPE
without CREATE TEMPORARY TABLE t2 (
`arrays` ARRAY<ARRAY<ARRAY<STRING>>>
) WITH (
'connector' = 'faker',
'fields.arrays.element.element.expression' = '#{harry_potter.character}',
'fields.arrays.element.element.length' = '2',
'fields.arrays.element.length' = '3',
'fields.arrays.length' = '4'
); |
snuyanzin
force-pushed
the
nested_collections
branch
from
b2b6500
to
515c243
Compare
snuyanzin
force-pushed
the
nested_collections
branch
from
515c243
to
87997da
Compare
|
Rebased |
snuyanzin
force-pushed
the
nested_collections
branch
from
87997da
to
1ede217
Compare
|
Rebased. |
snuyanzin
force-pushed
the
nested_collections
branch
from
1ede217
to
b7e7012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
within the PR I introduces a new POJO
FieldInfoand it simplifies to specifyexpressions,null-rate,lengthper any elements in case of complex types like maps of arrays of row and so on.In fact this PR will be in conflict with #21.
Once one of them will be merged I can rebase another one