Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent images layout on mobile devices #5960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohitsrma
Copy link

Resolved inconsistency in the layout of columns within the "Why serverless containers" section on mobile devices. Previously, images in the second row appearing differently than those in the first row.

Before

image

After

image

Copy link

linux-foundation-easycla bot commented May 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from csantanapr and ReToCode May 9, 2024 18:17
Copy link

knative-prow bot commented May 9, 2024

Welcome @rohitsrma! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fc7588b
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/663d134441791c0008848864
😎 Deploy Preview https://deploy-preview-5960--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierDipi
Copy link
Member

Thanks @rohitsrma

/cc @mmejia02 @zainabhusain227

@pierDipi
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants