Document Eventing istio integration #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
approved
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
pierDipi
force-pushed
the
document-istio
branch
2 times, most recently
from
132497b
to
1a90b25
Compare
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
removed
the
approved
knative-prow-robot
removed
the
needs-rebase
Cali0707
reviewed
May 14, 2024
config/nav.yml
Outdated
Comment on lines
289
to
291
| - Eventing with Istio: eventing/experimental-features/istio-integration.md | ||
| - Transport Encryption: eventing/experimental-features/transport-encryption.md | ||
| - Sender Identity: eventing/experimental-features/sender-identity.md |
There was a problem hiding this comment.
nit: let's keep the order in the nav the same as the order in the table of experimental features
Suggested change
| - Eventing with Istio: eventing/experimental-features/istio-integration.md | |
| - Transport Encryption: eventing/experimental-features/transport-encryption.md | |
| - Sender Identity: eventing/experimental-features/sender-identity.md | |
| - Transport Encryption: eventing/experimental-features/transport-encryption.md | |
| - Sender Identity: eventing/experimental-features/sender-identity.md | |
| - Eventing with Istio: eventing/experimental-features/istio-integration.md |
|
/hold I want to merge #5967 first |
knative-prow
bot
added
the
do-not-merge/hold
Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes knative-extensions/eventing-istio#21