Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too greedy TrackLink regex replacement. #2355

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Fix too greedy TrackLink regex replacement. #2355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion models/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ var regTplFuncs = []regTplFunc{
// Convert the shorthand https://google.com@TrackLink to {{ TrackLink ... }}.
// This is for WYSIWYG editors that encode and break quotes {{ "" }} when inserted
// inside <a href="{{ TrackLink "https://these-quotes-break" }}>.
// The regex matches all characters that may occur in an URL
// (see "2. Characters" in RFC3986: https://www.ietf.org/rfc/rfc3986.txt)
{
regExp: regexp.MustCompile(`(https?://.+?)@TrackLink`),
regExp: regexp.MustCompile(`(https?://[\p{L}_\-\.~!#$&'()*+,/:;=?@\[\]]*)@TrackLink`),
replace: `{{ TrackLink "$1" . }}`,
},

Expand Down