[Fixed #23] Fix all eslint syntax and style issues #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (27 commits) Added CURL example to README Added missing mongodb installation steps Renamed http_code to status_code Replaced image with one delivered from js.co.ke Updated banner Added banner image to readme Adding project banner Finished #17 Add installations steps to README Finished #22 Add field/params validation to /payment/request route Finished #10 Refactor ES6 import and any ES2015 feature not supported by Argon (Node.js v4.4.4.) Updated express and some of dependencies Updated /payment/request paymentDetails to use underscore notation on response Updated response JSON example in README Finshed #19 Wrap successful responses in response object Finished #20 Add sample request and response to README Finished #20 Add sample request and response to README Made /payment/request a POST request Replaced include method with indexOf while checking for extraParams Added payment request details to JSON response Added missing return code: 43 ...
* master: Updated README Removed an dependencies and usage of mongodb in the app, not really required at the moment
|
@gangachris @kn9ts Travis build seems to be failing, had you configured it? |
|
@denzelwamburu I haven't yet. I'm still considering using it. My preference is |
|
@kn9ts I haven't used before |
|
I have Created a Pull for Travis in case you consider using it #29 |
kn9ts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.