fix cleanup status

kkb0318 · Jul 18, 2024 · 77e3f52 · 77e3f52
1 parent de5d43f
commit 77e3f52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/v1alpha1/irsa_types.go b/api/v1alpha1/irsa_types.go
@@ -184,7 +184,7 @@ func setStatusServiceAccounts(s *StatusServiceAccountList, namespacedName types.
 
 func removeStatusServiceAccounts(s *StatusServiceAccountList, namespacedName types.NamespacedName) {
 	if s.IsExist(namespacedName) {
-		s.Append(namespacedName)
+		s.Delete(namespacedName)
 	}
 }
 

diff --git a/internal/controller/irsa_controller.go b/internal/controller/irsa_controller.go
@@ -205,7 +205,7 @@ func (r *IRSAReconciler) reconcile(ctx context.Context, obj *irsav1alpha1.IRSA,
 		kubeClient,
 		utils.DiffNamespacedNames(obj.Status.ServiceNamespacedNameList(), serviceAccount.NamespacedNameList()),
 	)
-	*obj = irsav1alpha1.IRSAStatusSetServiceAccount(*obj, deleted)
+	*obj = irsav1alpha1.IRSAStatusRemoveServiceAccount(*obj, deleted)
 	if err != nil {
 		e = err
 		reason = irsav1alpha1.IRSAReasonFailedK8sCleanUp