Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Obsolete features from Mouse Provider, fixes issue #8461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElliotGarbus
Copy link
Contributor

@ElliotGarbus ElliotGarbus commented Nov 16, 2023

This PR removes obsolete features from the mouse provider. This fixes issue #5898 The mouse provider had features that were used to interact with a scatter. These features were made obsolete by the multitouch_sim.

The removed features:

  • Pressing Shift + click would issue a double-tap
  • Pressing Alt during a drag would create a new touch
  • Holding Alt while pressing a mouse button would cancel drag

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

…use provider had features that were used to interact with a scatter using a mouse. These features were made obsolete by the multi-touch_sim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants