Try and get tight / loose working

kivikakk · Nov 22, 2024 · f96ea1d · f96ea1d
1 parent 2c35b13
commit f96ea1d
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 48 deletions.
diff --git a/src/html.rs b/src/html.rs
@@ -663,14 +663,15 @@ impl<'o> HtmlFormatter<'o> {
                     .map(|n| n.data.borrow().value.clone())
                 {
                     Some(NodeValue::List(nl)) => nl.tight,
+                    Some(NodeValue::DescriptionItem(nd)) => nd.tight,
                     _ => false,
                 };
 
-                let tight = tight
-                    || matches!(
-                        node.parent().map(|n| n.data.borrow().value.clone()),
-                        Some(NodeValue::DescriptionTerm)
-                    );
+                // let tight = tight
+                //     || matches!(
+                //         node.parent().map(|n| n.data.borrow().value.clone()),
+                //         Some(NodeValue::DescriptionTerm)
+                //     );
 
                 if !tight {
                     if entering {

diff --git a/src/nodes.rs b/src/nodes.rs
@@ -313,6 +313,10 @@ pub struct NodeDescriptionItem {
 
     /// Number of characters between the start of the list marker and the item text (including the list marker(s)).
     pub padding: usize,
+
+    /// Whether the list is [tight](https://github.github.com/gfm/#tight), i.e. whether the
+    /// paragraphs are wrapped in `<p>` tags when formatted as HTML.
+    pub tight: bool,
 }
 
 /// The type of list.

diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -1886,12 +1886,14 @@ impl<'a, 'o> Parser<'a, 'o> {
 
     fn parse_desc_list_details(&mut self, node: &mut &'a AstNode<'a>) -> bool {
         let container = node;
-
+        let mut tight = false;
+
         let last_child = match container.last_child() {
             Some(lc) => lc,
             None => {
                 // Happens when the detail line is directly after the term,
                 // without a blank line between.
+                tight = true;
                 *container = container.parent().unwrap();
                 container.last_child().unwrap()
             }
@@ -1942,6 +1944,7 @@ impl<'a, 'o> Parser<'a, 'o> {
             let metadata = NodeDescriptionItem {
                 marker_offset: self.indent,
                 padding: 2,
+                tight,
             };
 
             let item = self.add_child(
@@ -1960,12 +1963,14 @@ impl<'a, 'o> Parser<'a, 'o> {
 
             true
         } else if node_matches!(last_child, NodeValue::DescriptionItem(..)) {
+            // ORIGINAL CODE
             let parent = last_child.parent().unwrap();
             reopen_ast_nodes(parent);
 
             let metadata = NodeDescriptionItem {
                 marker_offset: self.indent,
                 padding: 2,
+                tight,
             };
 
             let item = self.add_child(
@@ -1980,6 +1985,27 @@ impl<'a, 'o> Parser<'a, 'o> {
             *container = details;
 
             true
+
+            // ATTEMPT 1
+            // reopen_ast_nodes(last_child);
+            // 
+            // let details =
+            //     self.add_child(last_child, NodeValue::DescriptionDetails, self.first_nonspace + 1);
+            // *container = details;
+            // 
+            // true
+
+            // ATTEMPT 2
+            // let parent = last_child.parent().unwrap();
+            // let item = parent.last_child().unwrap();
+            // 
+            // reopen_ast_nodes(item);
+            // 
+            // let details =
+            //     self.add_child(item, NodeValue::DescriptionDetails, self.first_nonspace + 1);
+            // *container = details;
+            // 
+            // true
         } else {
             false
         }

diff --git a/src/tests/fixtures/description_lists.md b/src/tests/fixtures/description_lists.md
@@ -11,9 +11,8 @@ with `:` (after 0-2 spaces); subsequent lines must
 be indented unless they are lazy paragraph
 continuations.
 
-There is no distinction between a "tight" list or a
-"loose" list. Definitions are always wrapped in `<p>`
-tags.
+The list is tight if there is no blank line between
+the term and the first definition, otherwise loose.
 
 ```````````````````````````````` example
 apple
@@ -24,13 +23,9 @@ orange
 .
 <dl>
 <dt>apple</dt>
-<dd>
-<p>red fruit</p>
-</dd>
+<dd>red fruit</dd>
 <dt>orange</dt>
-<dd>
-<p>orange fruit</p>
-</dd>
+<dd>orange fruit</dd>
 </dl>
 ````````````````````````````````
 
@@ -68,13 +63,9 @@ orange
 .
 <dl>
 <dt>apple</dt>
-<dd>
-<p>red fruit</p>
-</dd>
+<dd>red fruit</dd>
 <dt>orange</dt>
-<dd>
-<p>orange fruit</p>
-</dd>
+<dd>orange fruit</dd>
 </dl>
 ````````````````````````````````
 
@@ -101,8 +92,6 @@ orange
 
 Multiple blocks in a definition:
 
-Note that the column 
-
 ```````````````````````````````` example
 *apple*
 
@@ -161,7 +150,6 @@ term
 ````````````````````````````````
 
 Multiple definitions, tight:
-(always rendered as loose)
 
 ```````````````````````````````` example
 apple
@@ -174,19 +162,11 @@ orange
 .
 <dl>
 <dt>apple</dt>
-<dd>
-<p>red fruit</p>
-</dd>
-<dd>
-<p>computer company</p>
-</dd>
+<dd>red fruit</dd>
+<dd>computer company</dd>
 <dt>orange</dt>
-<dd>
-<p>orange fruit</p>
-</dd>
-<dd>
-<p>telecom company</p>
-</dd>
+<dd>orange fruit</dd>
+<dd>telecom company</dd>
 </dl>
 ````````````````````````````````
 
@@ -271,13 +251,9 @@ orange
 .
 <dl>
 <dt>apple</dt>
-<dd>
-<p>red fruit</p>
-</dd>
+<dd>red fruit</dd>
 <dt>orange</dt>
-<dd>
-<p>orange fruit</p>
-</dd>
+<dd>orange fruit</dd>
 </dl>
 ````````````````````````````````
 
@@ -315,12 +291,8 @@ bim
 <p>Foo</p>
 <dl>
 <dt>bar</dt>
-<dd>
-<p>baz</p>
-</dd>
+<dd>baz</dd>
 <dt>bim</dt>
-<dd>
-<p>bor</p>
-</dd>
+<dd>bor</dd>
 </dl>
 ````````````````````````````````