Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated jsrsasign, added new import options #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Updated jsrsasign, added new import options #2

wants to merge 11 commits into from

Conversation

bearbob
Copy link

@bearbob bearbob commented Sep 6, 2021

@kinosang
Copy link
Owner

kinosang commented Sep 6, 2021

Thanks for your contribution, but there're some issue about the changes.

@bearbob
Copy link
Author

bearbob commented Sep 18, 2023 •
edited
Loading

@kinosang Thanks for the suggestions - I committed them. And it is hard to put in words how I could have missed your review for more than 2 years! I will need a few days to recover from this... I only noticed now because @philippelatulippe told me...

@kinosang
Copy link
Owner

@kinosang Thanks for the suggestions - I committed them. And it is hard to put in words how I could have missed your review for more than 2 years! I will need a few days to recover from this... I only noticed now because @philippelatulippe told me...

@bearbob sorry for the delay. I'll do review and merge asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinosang kinosang Awaiting requested review from kinosang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearbob @kinosang