Skip to content
This repository has been archived by the owner on Nov 4, 2019. It is now read-only.

✨ Add input textarea component #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ Add input textarea component #128

wants to merge 1 commit into from

Conversation

XuTheBunny
Copy link
Contributor

Motivation

Create input textarea field with character count option.
image

Use Cases

  1. Kids First Data Tracker
    image

  2. Kids First Coordinator
    image
    image

  3. Kids First website
    image

API changes

No API changes are made on this component.

Implementation Notes

The validation for input value would be handled by the app. To show the error message, pass the string to error prop.
Textarea size would expand with its container.

Rendering and Storybook location

src/
└── components
    ├── InputTextarea
    │   ├── __tests__/
    │   ├── InputTextarea.jsx
    │   ├── InputTextarea.story.jsx
    │   └── InputTextarea.css
    └── index.js

Functional Tests

Test input textarea component with all prop value combinations.

@XuTheBunny XuTheBunny requested review from dankolbman and bdolly and removed request for dankolbman April 24, 2019 21:25
@XuTheBunny XuTheBunny self-assigned this Apr 24, 2019
@XuTheBunny XuTheBunny added component Involves a component feature New functionality labels Apr 24, 2019
@dankolbman
Copy link
Contributor

dankolbman commented Apr 24, 2019

UIKit Storybook for Review

Built with commit a4b1a0c

https://deploy-preview-128--kf-uikit.netlify.com

Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but the error wasn't being displayed for me in the storybook.
Also, do we want the label to align to the bottom of the box? It seems more helpful it it's at the top in the case of a really long text box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component Involves a component feature New functionality ready-for-review This PR needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants