[MBL-1650] Fix crashes with large WEBP images (#2085)

* adjust webp loading settings to have a max size based on screen resolution, downsample otherwise * apply the same fix for GIFs
kickstarter · Aug 1, 2024 · e4a37b1 · e4a37b1
1 parent b981ad6
commit e4a37b1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/app/src/main/java/com/kickstarter/ui/extensions/ImageViewExt.kt b/app/src/main/java/com/kickstarter/ui/extensions/ImageViewExt.kt
@@ -1,6 +1,7 @@
 package com.kickstarter.ui.extensions
 
 import android.content.Context
+import android.content.res.Resources
 import android.graphics.Color
 import android.graphics.drawable.ColorDrawable
 import android.graphics.drawable.Drawable
@@ -11,6 +12,7 @@ import com.bumptech.glide.integration.webp.decoder.WebpDrawable
 import com.bumptech.glide.integration.webp.decoder.WebpDrawableTransformation
 import com.bumptech.glide.load.engine.DiskCacheStrategy
 import com.bumptech.glide.load.engine.GlideException
+import com.bumptech.glide.load.resource.bitmap.DownsampleStrategy
 import com.bumptech.glide.load.resource.bitmap.RoundedCorners
 import com.bumptech.glide.request.RequestListener
 import com.bumptech.glide.request.RequestOptions
@@ -133,6 +135,8 @@ fun ImageView.loadWebp(url: String?, context: Context) {
             val roundedCorners = RoundedCorners(1)
             Glide.with(this)
                 .load(it)
+                .downsample(DownsampleStrategy.AT_LEAST)
+                .override(Resources.getSystem().displayMetrics.widthPixels, Resources.getSystem().displayMetrics.heightPixels)
                 .optionalTransform(roundedCorners)
                 .optionalTransform(WebpDrawable::class.java, WebpDrawableTransformation(roundedCorners))
                 .diskCacheStrategy(DiskCacheStrategy.AUTOMATIC)
@@ -144,13 +148,16 @@ fun ImageView.loadWebp(url: String?, context: Context) {
         }
     }
 }
+
 fun ImageView.loadGifImage(url: String?, context: Context) {
     url?.let {
         if (context.applicationContext.isKSApplication()) {
             try {
                 Glide.with(context)
                     .asGif()
                     .load(it)
+                    .downsample(DownsampleStrategy.AT_LEAST)
+                    .override(Resources.getSystem().displayMetrics.widthPixels, Resources.getSystem().displayMetrics.heightPixels)
                     .diskCacheStrategy(DiskCacheStrategy.AUTOMATIC)
                     .into(this)
             } catch (e: Exception) {

diff --git a/app/src/main/java/com/kickstarter/ui/views/ImageWithCaptionView.kt b/app/src/main/java/com/kickstarter/ui/views/ImageWithCaptionView.kt
@@ -50,11 +50,13 @@ class ImageWithCaptionView @JvmOverloads constructor(
                     binding.imageView.visibility = VISIBLE
                     binding.composeViewImage.visibility = GONE
                 }
+
                 src.isGif() -> {
                     binding.imageView.visibility = VISIBLE
                     binding.imageView.loadGifImage(src, context)
                     binding.composeViewImage.visibility = GONE
                 }
+
                 else -> {
                     binding.composeViewImage.visibility = VISIBLE
                     binding.imageView.visibility = GONE