MBL-1737: When user has no saved cards and stripe link fails or is ca…

…nceled there is a crash (cherry picked from commit fdf3f19)
kickstarter · Sep 16, 2024 · c8eb1f8 · c8eb1f8
1 parent 1544951
commit c8eb1f8
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/app/src/main/java/com/kickstarter/ui/activities/compose/projectpage/CheckoutScreen.kt b/app/src/main/java/com/kickstarter/ui/activities/compose/projectpage/CheckoutScreen.kt
@@ -562,7 +562,7 @@ private fun UpdateSelectedCardIfNewCardAdded(
     storedCards: List<StoredCard>,
     onOptionSelected: (StoredCard?) -> Unit
 ) {
-    if (index.value != storedCards.size) {
+    if (index.value != storedCards.size && storedCards.isNotEmpty()) {
         onOptionSelected(storedCards.first())
         index.value = storedCards.size
     }

diff --git a/app/src/main/java/com/kickstarter/ui/fragments/BackingAddOnsFragment.kt b/app/src/main/java/com/kickstarter/ui/fragments/BackingAddOnsFragment.kt
@@ -50,7 +50,13 @@ class BackingAddOnsFragment : Fragment() {
             }
 
             viewModelC.provideErrorAction { message ->
-                showErrorToast(context, this, message ?: getString(R.string.general_error_something_wrong))
+                activity?.runOnUiThread {
+                    showErrorToast(
+                        context,
+                        this,
+                        message ?: getString(R.string.general_error_something_wrong)
+                    )
+                }
             }
 
             // Dispose of the Composition when the view's LifecycleOwner

diff --git a/app/src/main/java/com/kickstarter/ui/fragments/CrowdfundCheckoutFragment.kt b/app/src/main/java/com/kickstarter/ui/fragments/CrowdfundCheckoutFragment.kt
@@ -167,7 +167,13 @@ class CrowdfundCheckoutFragment : Fragment() {
         } else {
             binding?.composeView?.let { view ->
                 context?.let {
-                    showErrorToast(it, view, error?.message ?: getString(R.string.general_error_something_wrong))
+                    activity?.runOnUiThread {
+                        showErrorToast(
+                            it,
+                            view,
+                            error?.message ?: getString(R.string.general_error_something_wrong)
+                        )
+                    }
                 }
             }
         }
@@ -197,15 +203,19 @@ class CrowdfundCheckoutFragment : Fragment() {
                 is PaymentSheetResult.Canceled -> {
                     binding?.composeView?.let { view ->
                         context?.let {
-                            showErrorToast(it, view, getString(R.string.general_error_oops))
+                            activity?.runOnUiThread {
+                                showErrorToast(it, view, getString(R.string.general_error_oops))
+                            }
                         }
                     }
                 }
                 is PaymentSheetResult.Failed -> {
                     binding?.composeView?.let { view ->
                         context?.let {
                             val errorMessage = paymentSheetResult.error.localizedMessage ?: getString(R.string.general_error_something_wrong)
-                            showErrorToast(it, view, errorMessage)
+                            activity?.runOnUiThread {
+                                showErrorToast(it, view, errorMessage)
+                            }
                         }
                     }
                 }