Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Offers Page #1582

Merged
merged 6 commits into from
Aug 10, 2024
Merged

Improved Offers Page #1582

merged 6 commits into from
Aug 10, 2024

Conversation

sau-mili
Copy link
Contributor

@sau-mili sau-mili commented Aug 5, 2024

Description

  • Added slideshow for top offers
  • Improved the other carousel slideshow
  • Improved the readability of the cards on hover

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Screenshot 2024-08-05 184745

Screenshot 2024-08-05 184722

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

github-actions bot commented Aug 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 2708ac0
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/66b65d4c09978a0008957140
😎 Deploy Preview https://deploy-preview-1582--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 7, 2024

@sunny0625 Please check this before merging other commits on same files. My PR is older than the recent commits.

@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 7, 2024

@sunny0625 I have resolved conflicts twice today, please check this

@sunny0625
Copy link
Collaborator

solve conflicts.

@sunny0625 sunny0625 added the gssoc GSSOC'24 issues label Aug 9, 2024
@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 9, 2024

solved please check. @sunny0625

@sunny0625 sunny0625 merged commit f4bcb37 into khushi-joshi-05:main Aug 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the offers page
2 participants