Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Food-ordering-website-mode modification #1569

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

rashi0409
Copy link
Contributor

@rashi0409 rashi0409 commented Aug 4, 2024

Description

This PR addresses corrections made to the dark and light modes, ensuring their visibility across all webpages, including Offers, Contact Us, Services, Menu, Home, and Login.

Related Issues

Modifications have been made to the Services dropdown menu for various pages to enhance its visibility. However, some parts remain unmodified.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update

Screenshots / videos (if applicable)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Further corrections can be made to the mode switching functionality to ensure that the Services dropdown list remains visible on the Rate Us page and a few others, making the user experience more impactful.

Copy link

github-actions bot commented Aug 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 68bbb19
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/66b62e9ec25ea40008ec393a
😎 Deploy Preview https://deploy-preview-1569--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rashi0409
Copy link
Contributor Author

rashi0409 commented Aug 5, 2024

@sunny0625 @khushi-joshi-05 I have made the pull request for issue (#1420) . Please check.

@sunny0625
Copy link
Collaborator

solve conflicts.

@sunny0625 sunny0625 added gssoc GSSOC'24 issues good first issue Good for newcomers level1 labels Aug 9, 2024
@rashi0409
Copy link
Contributor Author

rashi0409 commented Aug 9, 2024

@sunny0625 Resolved.

@sunny0625 sunny0625 merged commit 875f362 into khushi-joshi-05:main Aug 9, 2024
5 checks passed
@rashi0409
Copy link
Contributor Author

Thank you

@rashi0409 rashi0409 deleted the rtb branch August 10, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues in the light mode
2 participants