Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unique_id field for identifiying conversations #914

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

sabaimran
Copy link
Member

  • Add a new unique_id field which becomes the public-facing identifier for conversations
  • Update front-end and back-end pages to use it. Navigating to a specific conversation prefills it into the window, such as /chat?v={uniqueId}

- This helps us keep track of the unique identity of the conversation without expose the internal id
- Create three staged migrations in order to first add the field, then add unique values to pre-fill, and then set the unique constraint. Without this, it tries to initialize all the existing conversations with the same ID.
…front-end view

- Handle the unique_id field when creating a new conversation from the home page
- Parse the id field with a lightweight parameter called v in the chat page
- Share page should not be affected, as it uses the public slug
@sabaimran
Copy link
Member Author

Note: might be better to migrate to using unique_id everywhere for interactions with the Conversation object, not just in the web app.

@sabaimran sabaimran merged commit ece2ec2 into master Sep 16, 2024
9 checks passed
@sabaimran sabaimran deleted the features/use-unique-id-chat-view branch September 16, 2024 19:20
sabaimran added a commit that referenced this pull request Sep 19, 2024
…t to bulk update file filters"

This reverts commit c9665fb.

Revert "Fix handling for new conversation in agents page"

This reverts commit 3466f04.

Revert "Add a unique_id field for identifiying conversations (#914)"

This reverts commit ece2ec2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant