Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Khoj Emacs UX #812

Merged
merged 14 commits into from
Jun 16, 2024
Merged

Upgrade Khoj Emacs UX #812

merged 14 commits into from
Jun 16, 2024

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Jun 11, 2024 •
edited
Loading

Details

  • Khoj in Emacs Side pane
    • 906ebee Open Khoj chat, search in right pane to allow for ambient engagement
  • Improve Khoj Chat
    • 14c349a Show online references used for chat
    • ad53bb5 Make chat API call async to not block user interactions
    • cd4baa3 Fix loading chat history, references in khoj.el chat buffer
  • Improve Khoj Search, Find Similar functions
    • Make calls to Khoj search API async to not block user interactions
  • e214daf Support Conversation Sessions
    • Support opening, creating, deleting conversation sessions from the Khoj Emacs client

@debanjum
Fix loading chat history, references in khoj.el chat buffer
cd4baa3
@debanjum
Open Khoj chat, search in right pane to allow for ambient engagement
906ebee 
See the currently active window in context while doing chat, search
or find similar operations in a side pane.

This is similar to how we've moved Khoj on Obsidian into the side pane
as well
@debanjum debanjum force-pushed the upgrade-khoj-emacs-to-side-pane branch from e214daf to efe38a3 Compare June 13, 2024 03:00
@debanjum debanjum self-assigned this Jun 13, 2024
@debanjum
Show online references used for chat response as footnotes in Emacs
df9c5ff 
Previously online references used weren't being shown
@debanjum
Support conversation sessions in the Khoj Emacs client
7bcb49b 
Add option in khoj main transient menu option to open menu to
- switch between existing conversations
@debanjum
Create, use reusable function to call Khoj API from elisp
e21c064
@debanjum
Fix loading an empty chat session in Emacs
c33954c
@debanjum
Create new conversation from the chat menu in Khoj Emacs
055e5e8
@debanjum
Improve logic to create vs reuse window for khoj side pane logic
e15dc23 
Khoj side pane occupies a vertically split bottom right side pane.
If the bottom right window is not a vertical split, create a new
vertical split pane for khoj, otherwise reuse the existing window
@debanjum
Extract select conversation session logic into func for reusability
e3d995a
@debanjum
Delete old conversation sessions from the chat menu in Khoj Emacs
db056c8
@debanjum
Handle rendering messages using the old reference schema in khoj.el
c6b95f8 
Previously references were a list instead of a map
@debanjum
Make khoj.el search, similar API calls async to not block user intera…
2a84524 
…ctions
@debanjum
Remove short keys to switch content type during search to avoid conflict
fe36adb 
- C-x o to switch to search org content conflicts with switch buffer shortkey
  This is more apparent in the async search scenario as it prevents
  perform other actions while async search is in progress

- Also switching content type wouldn't scale to all the content types
  Khoj will support without causing more conflicting keybinding
@debanjum debanjum force-pushed the upgrade-khoj-emacs-to-side-pane branch from efe38a3 to fe36adb Compare June 15, 2024 12:06
@debanjum debanjum added fix Fix something that isn't working as expected upgrade New feature or request plugin Improvements or additions to content or UI integrations labels Jun 15, 2024
@debanjum debanjum merged commit d2d9f48 into master Jun 16, 2024
8 checks passed
@debanjum debanjum deleted the upgrade-khoj-emacs-to-side-pane branch June 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MythicalCow MythicalCow Awaiting requested review from MythicalCow

Assignees

@debanjum debanjum

Labels
fix Fix something that isn't working as expected plugin Improvements or additions to content or UI integrations upgrade New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@debanjum