Make win32 (mingw64) compatible #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tweaked some files so I could compile
gen_ft8.exeunder MSYS2 on Windows. I can rungen_ft8.exein Windows, and with it I have successfully created a .wav which could be opened and decoded by WSJT-X on Windows 10.test_ft8.exegives "Test OK" 3808 times. I have not yet tested any other binary outputs, but it all compiled successfully.Made this pull request in case you want to take the changes on. I understand if this project has no interest in maintaining Windows compatibility.
Main changes:
Added Windows/mingw64 fallbacks for
stpcpyandgmtime_r.USE_ASAN = 1has been added to the Makefile which allows you to turn on/off the flag-fsanitize=addressmore easily. This is because I needed to turn it off for mingw64 to get it to compile. But I've just left it on (i.e. unchanged), requiring manual editing to= 0for a Windows buildMy goal is to make a C# wrapper for ft8_lib. I'm no expert, just working out what I'm doing as I go.
Hope this is something useful and I haven't gone down the wrong path.