Skip to content

fix: possible integer overflow #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b4yuan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: possible integer overflow #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/wave.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void save_wav(const float* signal, int num_samples, int sample_rate, const char*
uint32_t chunkSize = 4 + (8 + subChunk1Size) + (8 + subChunk2Size);
char format[4] = { 'W', 'A', 'V', 'E' };

int16_t* raw_data = (int16_t*)malloc(num_samples * blockAlign);
int16_t* raw_data = (int16_t*)malloc((int16_t) num_samples * blockAlign);
Copy link
Copy Markdown

@szsam szsam Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be calloc(num_samples, blockAlign)

for (int i = 0; i < num_samples; i++)
{
float x = signal[i];
Expand Down Expand Up @@ -112,7 +112,7 @@ int load_wav(float* signal, int* num_samples, int* sample_rate, const char* path
*num_samples = subChunk2Size / blockAlign;
*sample_rate = sampleRate;

int16_t* raw_data = (int16_t*)malloc(*num_samples * blockAlign);
int16_t* raw_data = (int16_t*)calloc(*num_samples * blockAlign);
Copy link
Copy Markdown

@szsam szsam Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be calloc(*num_samples, blockAlign)


fread((void*)raw_data, blockAlign, *num_samples, f);
for (int i = 0; i < *num_samples; i++)
Expand Down
4 changes: 2 additions & 2 deletions decode_ft8.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ void monitor_init(monitor_t* me, const monitor_config_t* cfg)
me->fft_norm = 2.0f / me->nfft;
// const int len_window = 1.8f * me->block_size; // hand-picked and optimized

me->window = (float *)malloc(me->nfft * sizeof(me->window[0]));
me->window = (float *)calloc(me->nfft * sizeof(me->window[0]));
for (int i = 0; i < me->nfft; ++i)
{
// window[i] = 1;
Expand All @@ -128,7 +128,7 @@ void monitor_init(monitor_t* me, const monitor_config_t* cfg)
// me->window[i] = hamming_i(i, me->nfft);
// me->window[i] = (i < len_window) ? hann_i(i, len_window) : 0;
}
me->last_frame = (float *)malloc(me->nfft * sizeof(me->last_frame[0]));
me->last_frame = (float *)calloc(me->nfft * sizeof(me->last_frame[0]));

size_t fft_work_size;
kiss_fftr_alloc(me->nfft, 0, 0, &fft_work_size);
Expand Down