fix: fail on bootstrap download error #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a situation where a network glitch can cause a single file in the bootstrap to fail to download, but the bootstrap itself would continue. This tended to lead to strange site issues with missing files, which can be hard to trace. Fixes: #58
darcywong00
approved these changes
Mar 25, 2025
| @@ -58,7 +58,7 @@ function _bootstrap_download() { | |||
| curl -H "Cache-Control: no-cache" -fs "https://raw.githubusercontent.com/keymanapp/shared-sites/$BOOTSTRAP_VERSION/$remote_file" -o "$local_file" || ( | |||
| _bootstrap_echo "FATAL: Failed to download $remote_file" | |||
| exit 3 | |||
| ) | |||
| ) || exit $? | |||
There was a problem hiding this comment.
So is exit 3 not doing anything?
There was a problem hiding this comment.
It exits the subshell (...) but because it's in a pipe it doesn't fail the entire command. I didn't want to use set -o pipefail because of other possible side-effects
|
Note: given this change impacts only deployment, I am not preparing a new release for this PR. We can do a new release when we have other changes to deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a situation where a network glitch can cause a single file in the bootstrap to fail to download, but the bootstrap itself would continue. This tended to lead to strange site issues with missing files, which can be hard to trace.
Fixes: #58