Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for ESM commitlint config #6

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

kevintyj
Copy link
Owner

What is the purpose of this PR?

Add support for ESM based commitlint config files

ClickUp/Jira/Github project ticket number(s)?

What did you do?

Add a ESM to CJS conversion step for commitlint configuration files

How do we test it?

Unit tests through Vitest

Checklist before merging

  • Added tests where necessary
  • Performed a self-review of my code
  • Ensure all acceptance criteria are met
  • Implemented the UI as exactly as the design (applicable only for UI changes)
  • Added comments for codes where hard-to-understand
  • Haven't pushed unnecessary files (ex: .env, .map)
  • Haven't ignored Typescript warnings in the code (if do so add a comment with the reason)

Provide screenshot details of the PR

[optional] Tests passed screenshot

[optional] Breaking changes after PR

Anything else?

@kevintyj kevintyj merged commit 1d0ac4f into main Nov 24, 2023
2 checks passed
@kevintyj kevintyj deleted the feat/esm-to-cjs branch November 24, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant