Add piano key customization and improved styling by CSS variables #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great library! Thank you for sharing it.
I have made further enhancements by adding more customization options:
Added
renderKeyrender prop api for piano key customizationThis API allows developers to decide which keys are disabled. It exposes the entire Key component for greater customization.
Utilized
CSS variablesUsing CSS variables for styling provides greater convenience for developers and ensures compatibility with modern browsers.
Additionally, I replaced the package manager
yarnwithpnpm.pnpmoptimizes disk usage for node modules more efficiently. The latest versions ofyarn(v3+) introduce breaking changes that can be confusing for developers.I hope this helps!
Please review the commits. Thank you for this fantastic library.