Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insertion position for new controls when append or prepend options are enabled #1417

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

lucasnetau
Copy link
Collaborator

@lucasnetau lucasnetau commented Sep 19, 2023

This PR fixes the following issues:

  • Dragging a control onto the stage before a prepended field or after a appended field would show the drop placeholder and then silently cancel the drop on cursor release. We can fix this by relocating the placeholder with the jquery-ui.sortable change event
  • Adding a field by clicking on the control would insert the new control after a prepended field. Correctly set h.stopIndex to ensure controls are added before the prepended field
  • When sorting stage controls using the mobile sort buttons the sort handler did not take into account appended/prepended fields

Partial fix for #665

Copy link
Owner

@kevinchappell kevinchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much needed polish, good job

@kevinchappell kevinchappell merged commit 7d37d33 into kevinchappell:master Sep 21, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lucasnetau lucasnetau deleted the append branch September 21, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants