Add optional primary flag when creating a service.#167
Merged
kevincar merged 3 commits intokevincar:masterfrom Jan 13, 2026
Merged
Add optional primary flag when creating a service.#167kevincar merged 3 commits intokevincar:masterfrom
kevincar merged 3 commits intokevincar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a fix for issue #146 which has also caused me problems.
When creating services the current logic seems to be:
What this PR does is add a new optional primary parameter to add_new_service.
If set to None (the default), the existing logic above is used.
If set to True, the service is set to primary.
If set to False, the service isn't set as primary
(this has no effect on WinRT)
I've done some limited testing and it seems to work for me.
Thanks